Fix cube unit tests#2734
Merged
djkirkham merged 3 commits intoSciTools:dask_mask_arrayfrom Aug 17, 2017
Merged
Conversation
Closed
pelson
reviewed
Aug 16, 2017
| self.assertEqual(res_cell_methods.method, 'mean') | ||
|
|
||
|
|
||
| class Test_data_dtype_fillvalue(tests.IrisTest): |
Member
There was a problem hiding this comment.
I would consider it entirely reasonable calling these unit tests.
Member
Author
There was a problem hiding this comment.
I'm inclined to agree -- remember, this is not my code !
It could go back into iris.tests.unit.cube.test_Cube
I think I will do that...
Mind you, that is all a bit horribly bloated now.
Could maybe do with splitting up
Member
There was a problem hiding this comment.
Let's save that split for a rainy day... ☔️
djkirkham
approved these changes
Aug 16, 2017
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased version of #2726
Of which it was said...